fix: correct Prowlarr capabilities

[spdustin]

Description:

The current _get_indexer_from_json() private method only stores the first character of an indexer's movieSearchParams/tvSearchParams, resulting in Riven only providing the show/movie name to Prowlarr indexers even if they're able to search by year/season/episode.

This commit fixes the issue by removing the 0-slice from the list comprehension.

PR info

• No tests are included; this is fixing an issue with scrapers, for which there aren't any tests

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of movie and TV search capabilities in the Prowlarr integration.

• Style

  • Enhanced code formatting with a minor adjustment for better readability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request modify the _get_indexer_from_json method of the Prowlarr class, specifically how movie_search_capabilities and tv_search_capabilities are assigned. The implementation shifts from generator expressions to list comprehensions for better evaluation of indexer capabilities. Additionally, a minor formatting adjustment was made in the _log_indexers method by adding a newline at the end of the file.

Changes

File Path	Change Summary
src/program/services/scrapers/prowlarr.py	Modified _get_indexer_from_json: changed generator expression for capabilities to list comprehensions. Added newline in _log_indexers.

Poem

In the code where bunnies hop,
A change was made, we won't stop!
Capabilities now flow with grace,
In Prowlarr's heart, they find their place.
With a newline added, neat and bright,
Our code now shines, a pure delight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

src/program/services/scrapers/prowlarr.py (1)

221-221: Consider adding tests for indexer capabilities parsing.

While the PR notes that scrapers lack tests, this functionality is critical for search operations. Consider adding unit tests to verify:

• Correct parsing of search capabilities
• Proper category detection
• Generator expression evaluation

Would you like me to help create a test suite for this functionality?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4b726e5 and d420422.

📒 Files selected for processing (1)

• src/program/services/scrapers/prowlarr.py (2 hunks)

🔇 Additional comments (2)

src/program/services/scrapers/prowlarr.py (2)

221-221: LGTM! Fix correctly implements full search capabilities.

The change properly captures complete search parameters instead of just the first character, allowing Prowlarr to utilize all available search capabilities (year, season, episode, etc.).

---

265-265: LGTM! Proper file formatting.

Added newline at end of file following standard practice.