Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: workspace-level clippy configurations #4312

Closed
BugenZhao opened this issue Aug 1, 2022 · 2 comments · Fixed by #5508
Closed

clippy: workspace-level clippy configurations #4312

BugenZhao opened this issue Aug 1, 2022 · 2 comments · Fixed by #5508
Labels
type/chore type/enhancement Improvements to existing implementation.

Comments

@BugenZhao
Copy link
Member

Currently, we add a lot of clippy attributes at the root of each crate. It would be possible for us to forget to keep all crates consistent.

https://github.com/singularity-data/risingwave/blob/a15b40a28e86db1bb4d5c9b35f7303249d8102fd/src/stream/src/lib.rs#L16-L27

We may add them as rustc flags at .cargo/config.toml. An example:

https://github.com/EmbarkStudios/rust-ecosystem/blob/main/lints.toml

@BugenZhao BugenZhao added type/enhancement Improvements to existing implementation. type/chore labels Aug 1, 2022
@xxchan
Copy link
Member

xxchan commented Sep 22, 2022

upstream issue rust-lang/cargo#5034 🙏

@xxchan
Copy link
Member

xxchan commented Sep 22, 2022

I'm also hoping to use #![feature] at workspace level 🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore type/enhancement Improvements to existing implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants