Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace once_cell with LazyLock #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: replace once_cell with LazyLock #59

wants to merge 1 commit into from

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Aug 2, 2024 •
edited
Loading

wangrunji0408
wangrunji0408 approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Xuanwo
Copy link
Collaborator

Xuanwo commented Aug 3, 2024

Hi, thanks a lot for this PR. However, I believe it's too soon to upgrade since Rust 1.80 was introduced just a few days ago. I'd prefer not to set our MSRV to 1.80 at the moment.

@Xuanwo
Copy link
Collaborator

Xuanwo commented Aug 3, 2024 •
edited
Loading

For instance, DataFusion is attempting to use arrow-udf as seen at apache/datafusion#11488, which has a MSRV of 1.76. I don't want to break their progress.

@PsiACE
Copy link
Member Author

PsiACE commented Aug 3, 2024

For instance, DataFusion is attempting to use arrow-udf as seen at apache/datafusion#11488, which has a MSRV of 1.76. I don't want to break their progress.

Yes, we can wait until apache/datafusion#11690 is merged.

@Xuanwo
Copy link
Collaborator

Xuanwo commented Aug 3, 2024 •
edited
Loading

Yes, we can wait until apache/datafusion#11690 is merged.

Sorry, please allow me to make it more clear: I think we should wait for our users change their MSRV to 1.80.

At this point, it means datafusion: the most important user I want to catch up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favoring LazyLock over lazy_static
3 participants
@PsiACE @Xuanwo @wangrunji0408