Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

described MTT lookup process #58

Merged
merged 13 commits into from
Aug 27, 2024
Merged

described MTT lookup process #58

merged 13 commits into from
Aug 27, 2024

Conversation

rsahita
Copy link
Collaborator

@rsahita rsahita commented Jul 8, 2024

addressing missing MTT lookup process (Issue #49 )

@rsahita
described MTT lookup process
566a16a 
Signed-off-by: Ravi Sahita <[email protected]>
@rsahita rsahita mentioned this pull request Jul 8, 2024
Closed
@rsahita
described MTT lookup process
845ae68 
Signed-off-by: Ravi Sahita <[email protected]>
@rsahita rsahita mentioned this pull request Jul 8, 2024
Closed
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
eckhard-delfs-qualcomm
eckhard-delfs-qualcomm reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 9, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Jul 11, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Jul 11, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Jul 11, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Jul 11, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Jul 11, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
eckhard-delfs-qualcomm
eckhard-delfs-qualcomm reviewed Jul 16, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Jul 16, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
@rsahita
fix typo in fig3
12a0c66 
Signed-off-by: Ravi Sahita <[email protected]>
ved-rivos
ved-rivos reviewed Aug 15, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Aug 15, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Aug 15, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Aug 15, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Aug 15, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Aug 15, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Aug 15, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Aug 16, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Aug 16, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
eckhard-delfs-qualcomm
eckhard-delfs-qualcomm reviewed Aug 19, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Aug 19, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Aug 19, 2024
View reviewed changes
chapter4.adoc Outdated Show resolved Hide resolved
rsahita and others added 3 commits August 19, 2024 12:29
@rsahita @ved-rivos @eckhard-delfs-qualcomm
Apply suggestions from PR review
f064abf 
Co-authored-by: Ved Shanbhogue <[email protected]>
Co-authored-by: eckhard-delfs-qualcomm <[email protected]>
Signed-off-by: Ravi Sahita <[email protected]>
@rsahita
Updates to distinguish MTT for XLEN = 32 clearly
eb7616d 
Signed-off-by: Ravi Sahita <[email protected]>
@rsahita
added some minor missing fixes in text
3bbe2ba 
Signed-off-by: Ravi Sahita <[email protected]>
@rsahita
Copy link
Collaborator Author

rsahita commented Aug 20, 2024 •
edited
Loading

Please look at the last build check artifact to review the PDF version -
new link below.

@rsahita
Copy link
Collaborator Author

rsahita commented Aug 23, 2024 •
edited
Loading

Updated draft link below.

eckhard-delfs-qualcomm
eckhard-delfs-qualcomm reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@eckhard-delfs-qualcomm eckhard-delfs-qualcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me, just a few minor comments.

chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
chapter4.adoc Outdated Show resolved Hide resolved
@rsahita @eckhard-delfs-qualcomm
Apply suggestions from PR review
2f42ed6 
Co-authored-by: eckhard-delfs-qualcomm <[email protected]>
Signed-off-by: Ravi Sahita <[email protected]>
@rsahita
Copy link
Collaborator Author

rsahita commented Aug 26, 2024

Updated draft link -> https://github.com/riscv/riscv-smmtt/actions/runs/10563011302/artifacts/1855303902

@rsahita rsahita self-assigned this Aug 26, 2024
@rsahita rsahita merged commit b399126 into main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ved-rivos ved-rivos ved-rivos left review comments

@eckhard-delfs-qualcomm eckhard-delfs-qualcomm eckhard-delfs-qualcomm left review comments

@kasanovic kasanovic kasanovic approved these changes

Assignees

@rsahita rsahita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsahita @kasanovic @ved-rivos @eckhard-delfs-qualcomm