Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm offset in CallCFunctionHelper #378

Open
ghost opened this issue Dec 31, 2020 · 2 comments
Open

Confirm offset in CallCFunctionHelper #378

ghost opened this issue Dec 31, 2020 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@ghost
Copy link

ghost commented Dec 31, 2020

This FIXME needs to be checked and fixed or removed. It seems correct, or else I would expect some tests to fail, but someone needs to go through and confirm.

    auipc(pc_scratch, 0);
    // FIXME(RISCV): Does this need an offset? It seems like this should be the
    // PC of the call, but MIPS does not seem to do that.
@ghost ghost added the question Further information is requested label Dec 31, 2020
@luyahan
Copy link
Collaborator

luyahan commented Mar 17, 2021

In arm64 it's offset is also 0.

  Label get_pc;
  Bind(&get_pc);
  Adr(pc_scratch, &get_pc);

@luyahan
Copy link
Collaborator

luyahan commented Feb 14, 2022

see arm:

  // Save the frame pointer and PC so that the stack layout remains iterable,
  // even without an ExitFrame which normally exists between JS and C frames.

This should save current pc to stack. So we can delete fixme

@luyahan luyahan closed this as completed Feb 14, 2022
@luyahan luyahan reopened this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant