getOrderbook - return raw order data

[intelliot]

Include the full BookOffer data under data

Fix #799

[FredKSchott]

Code looks good, but isn't this a better use case for:

await api._requestAll('book_offers', { ... });

Or is the idea that a public consumer wants this sooner rather than later? Maybe in addition to merging this PR, I could spend some of my sprint this week finalizing request()/requestAll() so that we can get closer to making them public.

@intelliot what do you think?

[sublimator]

@FredKSchott

spend some of my sprint
Is that some of the fabled 20% time at Google?

[intelliot]

@FredKSchott I don't think we should transparently make multiple requests behind-the-scenes. Pagination exists to prevent overloading the rippled server. If we wanted to request all at once, we'd make a change in rippled. However, rippled already supports this: developers already get all of the results when they're on an 'admin' connection.

Yes, we should finalize request(). Here's one proposal for doing it: #887

[FredKSchott]

@intelliot +1, I like the approach in #887 even better. I'll try to take a look this week

[wilsonianb]

LGTM 👍