Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Payment Channel documentation #877

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Improve Payment Channel documentation #877

merged 1 commit into from
Mar 31, 2018

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Mar 28, 2018 •
edited
Loading

  • Adds the PayChan types to the transaction types list. (Pointed out by @michielbdejong )
  • Adds more specificity to some of the PayChan field descriptions
  • Corrects a reversal of the Balance and Amount fields in the PaymentChannelClaim documentation.

@mDuo13 mDuo13 requested a review from intelliot March 28, 2018 18:56
intelliot
intelliot approved these changes Mar 30, 2018
View reviewed changes
Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@ryangyoung
Copy link
Contributor

Thanks for the review, @intelliot!

@mDuo13 mDuo13 merged commit c71540e into XRPLF:develop Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelliot intelliot intelliot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mDuo13 @ryangyoung @intelliot