-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "browser" property to package.json #847
Conversation
Need to run `build` script for this file to exist
@mikeb1rd Could you verify that this solution works for you? |
Note that you'll need to go inside
|
@intelliot that's right, you would build these files on every publish to npm. Edit: Oh wait, no, |
Done in 9a789ce. I also bumped the engine version to ">=6.12.3" since that's the version I use and I don't think anyone regularly tests on earlier versions of node. |
|
Okay, I have a working solution now. With bbfc53e, instead of using the webpack build, we are just substituting This worked for me; @mikeb1rd could you give it a try? |
package.json
Outdated
@@ -64,7 +67,7 @@ | |||
"clean": "rm -rf dist/npm", | |||
"compile": "mkdir -p dist/npm/common && cp -r src/common/schemas dist/npm/common/ && tsc", | |||
"watch": "tsc -w", | |||
"prepublish": "npm run clean && npm run compile", | |||
"prepublish": "npm run clean && npm run compile && npm run build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be reverted now, as the built files are not used
@intelliot Thanks for spending time on this. I've just added one comment, otherwise the solution works well. |
This should be an alternative to #840
We need to run thebuild
script for this file to exist, so how should we handle that?Perhaps we can just make sure "./build/ripple-latest.js" is prebuilt and published to npm?See also: #844 (comment)