fix flow type errors #811
fix flow type errors #811
Conversation
| @@ -27,6 +27,7 @@ function toRippledAmount(amount: Amount): RippledAmount { | |||
| if (amount.currency === 'XRP') { | |||
| return xrpToDrops(amount.value) | |||
| } | |||
| // $FlowFixMe: amount.issuer is not a Amount type property. Safe to remove? | |||
There was a problem hiding this comment.
Good catch. issuer is actually the term that we use in rippled. We should add issuer to the Amount type, and keep using it here. (No hurry, but in a future release, we may deprecate counterparty.)
There was a problem hiding this comment.
(There are other areas in the code that will need to be updated to accommodate this)
There was a problem hiding this comment.
@intelliot Say more about the other areas that need to be changed? They'll need to accommodate by setting issuer? Read from issuer?
There was a problem hiding this comment.
@FredKSchott Right. For example, here are places where I think we'll need to set issuer or read from issuer. We can do this in a later PR though.
src/transaction/settings.js
Outdated
| import type {Settings} from './settings-types.js' | ||
|
|
||
| type Settings = { | ||
| passwordSpent?: boolean; |
There was a problem hiding this comment.
I believe we prefer to use commas instead of semicolons here.
FredKSchott
force-pushed
the
fix-flow-types
branch
from
9d529d5 to
28bfbf0
Compare
| @@ -27,6 +27,7 @@ function toRippledAmount(amount: Amount): RippledAmount { | |||
| if (amount.currency === 'XRP') { | |||
| return xrpToDrops(amount.value) | |||
| } | |||
| // $FlowFixMe: amount.issuer is not a Amount type property. Safe to remove? | |||
There was a problem hiding this comment.
@FredKSchott Right. For example, here are places where I think we'll need to set issuer or read from issuer. We can do this in a later PR though.
|
We can clean up counterparty/issuer in a later PR :) Merging. |
|
👍 👍 👍 |
This gets flow passing again on the codebase (a result of running #810)