Skip to content

Add core build #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2014
Merged

Add core build #205

merged 4 commits into from
Nov 12, 2014

Conversation

wltsmrz
Copy link
Contributor

@wltsmrz wltsmrz commented Nov 11, 2014

Add a "core" browser build of ripple-lib which has a subset of features and smaller file size

Restrictions

  • No transaction submission
  • No orderbook tracking
  • No Account class
  • No SerializedObject class. The only implication for this build is that you won't be able to request binary account_tx

Using an unavailable class (e.g. calling remote#createTransaction) will throw an error such as Error: Class is unavailable in this build: Transaction

Results

$ du -k build/*
172 build/ripple-0.9.2-rc5-core.js
856 build/ripple-0.9.2-rc5-debug.js
832 build/ripple-0.9.2-rc5.js
328 build/ripple-0.9.2-rc5-min.js
132 build/sjcl.js

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) when pulling 8f17873 on core-build into 261b72d on develop.

@wltsmrz
Copy link
Contributor Author

wltsmrz commented Nov 11, 2014

@justmoon

@geertweening
Copy link
Contributor

@wltsmrz can you add some documentation around the purpose of this build and for what cases it should be used. I would also like to understand better why orderbook, account, transaction, serializedobject are excluded, but other parts of the library are still included. Such as vaultclient, transactionmanager, transactionqueue.

@wltsmrz
Copy link
Contributor Author

wltsmrz commented Nov 11, 2014

I'm not sure where documentation should be added. I'll add a release note when this is merged

As the entry point is remote.js and account.js is disabled, none of the classes you mentioned (vaultclient.js transactionmanager.js transactionqueue.js) will be included

@geertweening
Copy link
Contributor

Can you add a 'build' paragraph to the README? This would fit nicely in there.

@justmoon
Copy link
Contributor

Agree on adding docs. Implementation-wise looking good!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) when pulling 5a0821e on core-build into 261b72d on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) when pulling 3650858 on core-build into 3ee7998 on develop.

geertweening added a commit that referenced this pull request Nov 12, 2014
@geertweening geertweening merged commit df763b8 into develop Nov 12, 2014
@wltsmrz wltsmrz deleted the core-build branch December 13, 2014 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants