Skip to content

Commit aa7c13b

Browse files
committed
updated Makefile to use multiple tags
1 parent 794439e commit aa7c13b

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

Makefile

+6-5
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ BASE_IMAGE_ENVIRONMENT_PREVIOUS = ubuntu:${UBUNTU_VERSION_PREVIOUS}#"nvidia/open
1818

1919

2020
# Tag: latest
21-
BUILD_IMAGE_LATEST = $(IMAGE):latest
21+
BUILD_IMAGE_LATEST = $(IMAGE):${UBUNTU_VERSION_LATEST}
2222
BUILD_IMAGE_PREVIOUS = $(IMAGE):${UBUNTU_VERSION_PREVIOUS}
2323

2424

@@ -44,11 +44,11 @@ post-push:
4444

4545
docker-build:
4646

47-
# Build latest
48-
docker buildx build --build-arg="UBUNTU_VERSION=${UBUNTU_VERSION_LATEST}" --platform linux/arm/v7,linux/arm64/v8,linux/amd64 --tag $(BUILD_IMAGE_LATEST) -f Dockerfile .
47+
# Build latest with multiple tags
48+
docker buildx build --build-arg="UBUNTU_VERSION=${UBUNTU_VERSION_LATEST}" --platform linux/arm64/v8,linux/amd64 --tag $(BUILD_IMAGE_LATEST) --tag $(IMAGE):latest -f Dockerfile .
4949

5050
# Build previous
51-
docker buildx build --build-arg="UBUNTU_VERSION=${UBUNTU_VERSION_PREVIOUS}" --platform linux/arm/v7,linux/arm64/v8,linux/amd64 --tag $(BUILD_IMAGE_PREVIOUS) -f Dockerfile .
51+
docker buildx build --build-arg="UBUNTU_VERSION=${UBUNTU_VERSION_PREVIOUS}" --platform linux/arm64/v8,linux/amd64 --tag $(BUILD_IMAGE_PREVIOUS) -f Dockerfile .
5252

5353

5454
release: build push ## builds a new version of your container image(s), and pushes it/them to the registry
@@ -58,14 +58,15 @@ push: pre-push do-push post-push ## pushes the images to dockerhub
5858

5959
do-push:
6060
# Push lateset
61-
docker buildx build --build-arg="UBUNTU_VERSION=${UBUNTU_VERSION_LATEST}" --platform linux/arm64/v8,linux/amd64 --push --tag $(BUILD_IMAGE_LATEST) -f Dockerfile .
61+
docker buildx build --build-arg="UBUNTU_VERSION=${UBUNTU_VERSION_LATEST}" --platform linux/arm64/v8,linux/amd64 --push --tag $(BUILD_IMAGE_LATEST) --tag $(IMAGE):latest -f Dockerfile .
6262

6363
# Push previous
6464
docker buildx build --build-arg="UBUNTU_VERSION=${UBUNTU_VERSION_PREVIOUS}" --platform linux/arm64/v8,linux/amd64 --push --tag $(BUILD_IMAGE_PREVIOUS) -f Dockerfile .
6565

6666

6767
cleanup: ## Remove images pulled/generated as part of the build process
6868
docker rmi $(BUILD_IMAGE_LATEST)
69+
docker rmi $(IMAGE):latest
6970
docker rmi $(BUILD_IMAGE_PREVIOUS)
7071
docker rmi $(BASE_IMAGE_ENVIRONMENT_LATEST)
7172
docker rmi $(BASE_IMAGE_ENVIRONMENT_PREVIOUS)

0 commit comments

Comments
 (0)