feat: fix incorrect private set when ~MemberVisibility.Accessible is used
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
==========================================
+ Coverage 91.49% 91.50% +0.01%
==========================================
Files 215 215
Lines 7217 7216 -1
Branches 873 873
==========================================
Hits 6603 6603
+ Misses 408 407 -1
Partials 206 206 ☔ View full report in Codecov by Sentry. |
TimothyMakkison
force-pushed
the
private_set
branch
from
f382477
to
75778ad
Compare
latonz
requested changes
Nov 21, 2023
TimothyMakkison
force-pushed
the
private_set
branch
from
75778ad
to
bae8838
Compare
latonz
approved these changes
Nov 21, 2023
|
Thank you for the fast fix! Do you have an ETA on when the next release will be available in nuget? |
|
🎉 This PR is included in version 3.3.0-next.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
A preview release including this bug fix is published. We don't have an ETA on the next stable release, probably in a couple weeks. |
|
Thank you very much! |
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: fix incorrect
private setwhen~MemberVisibility.Accessibleis usedDescription
Prevents the invalid generation of set to a
private setproperty if~MemberVisibility.Accessibleis used.Fixes #932
Checklist