Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: obsolete constructors are not considered last #893

Closed
latonz opened this issue Nov 13, 2023 · 2 comments · Fixed by #898
Closed

Regression: obsolete constructors are not considered last #893

latonz opened this issue Nov 13, 2023 · 2 comments · Fixed by #898
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@latonz
Copy link
Contributor

latonz commented Nov 13, 2023

In commit ff51d7d in Riok.Mapperly.Descriptors.MappingBodyBuilders.NewInstanceObjectMemberMappingBodyBuilder.BuildConstructorMapping the ObsoleteAttribute accidentally got changed to MapperConstructorAttribute (ThenBy ordering). This should be changed back to restore the documented constructor ordering. Ensure this behaviour is covered by unit tests.
@latonz latonz added enhancement New feature or request good first issue Good for newcomers labels Nov 13, 2023
@latonz latonz mentioned this issue Nov 13, 2023
Closed
@ni507 ni507 mentioned this issue Nov 14, 2023
Closed
@latonz latonz mentioned this issue Nov 14, 2023
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.3.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: obsolete constructors should have the last priority whlie matching constructors (regression)
1 participant
@latonz