Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix spacing for casts and enum parse mappings #747

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: fix spacing for casts and enum parse mappings #747

merged 1 commit into from
Sep 13, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Sep 12, 2023

Remove NoramlizeWhitespace in unit tests to ensure correct formatting in unit tests.

Rel. #746 (comment)
Additional changes in formatting to #706:

  • Enum parsing mapping: space in braces is removed: {} s when s.Equals(nameof(source.Value1), StringComparison.OrdinalIgnoreCase) => ... instead of { } s when s.Equals(nameof(source.Value1), StringComparison.OrdinalIgnoreCase) => ....

Changes to fix formatting introduced in #706:

  • Enum parsing mapping: Adds a space between {} and s
  • Dictionary mapping if only explicit interface implementation: indent variable declaration correctly
  • Indent throw argument null exception throws correctly

@latonz latonz self-assigned this Sep 12, 2023
Remove NoramlizeWhitespace in unit tests to ensure correct formatting in unit tests
@latonz latonz enabled auto-merge (squash) September 12, 2023 15:21
@latonz latonz requested a review from ni507 September 12, 2023 15:23
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #747 (ddb8b49) into main (4fa4163) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   91.44%   91.36%   -0.08%     
==========================================
  Files         201      201              
  Lines        6651     6651              
  Branches      821      821              
==========================================
- Hits         6082     6077       -5     
- Misses        380      385       +5     
  Partials      189      189              
Files Changed Coverage Δ
...tors/Mappings/Enums/EnumFromStringSwitchMapping.cs 100.00% <100.00%> (ø)
...arget/ForEachSetDictionaryExistingTargetMapping.cs 100.00% <100.00%> (ø)
...perly/Emit/Syntax/SyntaxFactoryHelper.Condition.cs 98.24% <100.00%> (ø)
...k.Mapperly/Emit/Syntax/SyntaxFactoryHelper.Null.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz merged commit 137f2fb into riok:main Sep 13, 2023
18 of 19 checks passed
@latonz latonz deleted the fix/formatting branch September 13, 2023 05:54
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants