Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use all modifiers for user method mapping #734

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

ni507
Copy link
Contributor

@ni507 ni507 commented Sep 7, 2023

Fixes #639

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #734 (2087ca4) into main (3e60dc2) will increase coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
+ Coverage   91.32%   91.34%   +0.01%     
==========================================
  Files         201      201              
  Lines        6662     6654       -8     
  Branches      821      820       -1     
==========================================
- Hits         6084     6078       -6     
+ Misses        386      384       -2     
  Partials      192      192              
Files Changed Coverage Δ
...c/Riok.Mapperly/Emit/Syntax/SyntaxFactoryHelper.cs 93.65% <ø> (+1.86%) ⬆️
...iok.Mapperly/Descriptors/Mappings/MethodMapping.cs 95.31% <81.81%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ni507 ni507 requested a review from latonz September 7, 2023 12:03
@ni507 ni507 force-pushed the 639-method-modifiers branch 2 times, most recently from 5066783 to d571dc1 Compare September 7, 2023 12:49
@latonz latonz merged commit dcb2eff into riok:main Sep 8, 2023
18 of 19 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.2.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual/override mapper methods cause compile errors
2 participants