fix: generate correct nullability for external array elements #715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate correct nullability for external array elements
Description
Using
ImplementsGeneric
on external types will erase the nullable annotation of an array element type. This is used inCollectionInfosBuilder.GetEnumeratedType
where the resulting enumerated type is used byEnumerableMappingBuilder
to map the element types of two collections.This caused a rare issue where an array collection would be treated as if it had a nullable element type.
Fixes #690
Checklist