feat: remove the Riok.Mapperly.Abstractions runtime dependency #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 91.21% 91.32% +0.11%
==========================================
Files 198 201 +3
Lines 6601 6662 +61
Branches 820 821 +1
==========================================
+ Hits 6021 6084 +63
+ Misses 389 386 -3
- Partials 191 192 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CommonGuy
reviewed
Sep 5, 2023
Creates a new Riok.Mapperly.Templates project with templates. Some Mapperly features may require such a template (currently only the reference handling). If such a template is required by a used Mapperly feature, Mapperly emites the template in a namespace which includes the name of the assembly of the target project. This is done to prevent collisions when using InternalsVisibleTo (see #685). Currently the only themplate is the PreserveReferenceHandler which is emitted if reference handling is enabled for any mapper and the mapper does have mapper method definitions without a reference handling parameter and Mapperly needs to instantiate a IReferenceHandler.
CommonGuy
approved these changes
Sep 5, 2023
|
🎉 This PR is included in version 3.2.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the Riok.Mapperly.Abstractions runtime dependency
Description
Creates a new Riok.Mapperly.Templates project with templates. Some Mapperly features may require such a template (currently only the reference handling). If such a template is required by a used Mapperly feature, Mapperly emites the template in a namespace which includes the name of the assembly of the target project. This is done to prevent collisions when using
InternalsVisibleTo(see #685).Currently the only template is the PreserveReferenceHandler which is emitted if reference handling is enabled for any mapper and the mapper does have mapper method definitions without a reference handling parameter and Mapperly needs to instantiate a IReferenceHandler.
The runtime dependency can be removed by setting
PrivateAssets="all" ExcludeAssets="runtime"on the package reference. Unluckily we cannot setdevelopmentDependency=trueon the NuGet, since this would exclude the compile assets which are required for a source generator. See also NuGet/Home#10746.Fixes #685
Checklist