Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent null initializing readonly members #678

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

TimothyMakkison
Copy link
Collaborator

@TimothyMakkison TimothyMakkison commented Aug 24, 2023

Prevent null initializing readonly members

Description

  • Add check to container builder context for readonly members
  • Added test

Fixes #653

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Unit tests are added/updated

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #678 (46169e1) into main (71cbfdd) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   90.81%   90.98%   +0.16%     
==========================================
  Files         172      172              
  Lines        6130     6132       +2     
  Branches      780      781       +1     
==========================================
+ Hits         5567     5579      +12     
+ Misses        387      377      -10     
  Partials      176      176              
Files Changed Coverage Δ
...s/BuilderContext/MembersContainerBuilderContext.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz merged commit f3d78b4 into riok:main Aug 28, 2023
17 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.2.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping nested properties will null initialize getter only properties
2 participants