-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add embed node #888
Open
YannikSc
wants to merge
4
commits into
rinja-rs:main
Choose a base branch
from
YannikSc:feature/embed_block
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+209
−1
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{# The embedded template, which again extends another template and overrides a block (just to test the complexity) #} | ||
|
||
{% extends "embed_base_base.html" %} | ||
|
||
{% block title %} | ||
<h1>Hello {{ user.name }}</h1> | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{# The base template which is going to be embedded. Could be a responsive container for example #} | ||
<div> | ||
{% block title %} | ||
<h1>Hello anonymous</h1> | ||
{% endblock %} | ||
{% block content %}{% endblock %} | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{# Base template which gets rendered used for the struct, embedding another template #} | ||
|
||
<body> | ||
{% embed "embed_base.html" %} | ||
{% block content %}<p>Welcome to this example!</p>{% endblock %} | ||
{% endembed %} | ||
</body> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
use askama::Template; | ||
|
||
struct FakeUser { | ||
name: String, | ||
} | ||
|
||
#[derive(Template)] | ||
#[template(path = "embed_parent.html")] | ||
struct EmbedTemplate { | ||
user: FakeUser, | ||
} | ||
|
||
fn strip_whitespaces(string: &str) -> String { | ||
string | ||
.split_whitespace() | ||
.filter(|char| !char.is_empty()) | ||
.collect::<Vec<_>>() | ||
.join(" ") | ||
.trim_end() | ||
.trim_start() | ||
.to_string() | ||
} | ||
|
||
#[test] | ||
fn test_embed() { | ||
let expected = strip_whitespaces( | ||
r#" | ||
<body> | ||
<div> | ||
<h1>Hello Yannik</h1> | ||
<p>Welcome to this example!</p> | ||
</div> | ||
</body>"#, | ||
); | ||
let template = EmbedTemplate { | ||
user: FakeUser { | ||
name: String::from("Yannik"), | ||
}, | ||
}; | ||
let rendered = strip_whitespaces(&template.render().unwrap()); | ||
|
||
assert_eq!(rendered, expected); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's missing errors for doing anything outside block tags. Some of these don't actually do anything (extends for example gets overwritten), but you're allowed to write macro and include nodes here, which seems weird (this is similar behavior to how normal extended templates work, so maybe not a real issue?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I see why this is problematic, but it's consistent. I think this is something, that should be fixed/improved in general.
Another real problem, that I mentioned in the issue (#488) is, that the compiler is not including the file when the
embed
is inside ablock
in anextend
ed file. This problem however also exists forinclude
s and I'm not sure how to approach this.