From de39baa67047a049d037c92c576485e8b7192fe5 Mon Sep 17 00:00:00 2001
From: Timothee Cour <timothee.cour2@gmail.com>
Date: Fri, 20 Nov 2020 14:16:59 -0800
Subject: [PATCH] followup #15970 strenghten regression tests (#16075)

* followup #15970 strenghten regression tests

* _
---
 tests/lent/tbasic_lent_check.nim | 27 +++++++++++++++------------
 tests/misc/taddr.nim             |  5 ++---
 2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/tests/lent/tbasic_lent_check.nim b/tests/lent/tbasic_lent_check.nim
index e22f7bb5088e..049fa276a011 100644
--- a/tests/lent/tbasic_lent_check.nim
+++ b/tests/lent/tbasic_lent_check.nim
@@ -1,5 +1,5 @@
 discard """
-  targets: "c cpp"
+  targets: "c cpp js"
   output: "1"
 """
 
@@ -16,29 +16,28 @@ proc main =
 
 main()
 
-
-#------------------------------------------------------------------------------
-# issue #15958
-
-block:
+template main2 = # bug #15958
   proc byLent[T](a: T): lent T = a
   let a = [11,12]
-  let b = @[21,23]  
+  let b = @[21,23]
   let ss = {1, 2, 3, 5}
   doAssert byLent(a) == [11,12]
   doAssert byLent(a).unsafeAddr == a.unsafeAddr
   doAssert byLent(b) == @[21,23]
-  doAssert byLent(b).unsafeAddr == b.unsafeAddr
+  when not defined(js): # pending bug #16073
+    doAssert byLent(b).unsafeAddr == b.unsafeAddr
   doAssert byLent(ss) == {1, 2, 3, 5}
   doAssert byLent(ss).unsafeAddr == ss.unsafeAddr
 
   let r = new(float)
   r[] = 10.0
-  doAssert byLent(r)[] == 10.0
+  when not defined(js): # pending bug #16073
+    doAssert byLent(r)[] == 10.0
 
-  let p = create(float)
-  p[] = 20.0
-  doAssert byLent(p)[] == 20.0
+  when not defined(js): # pending bug https://github.com/timotheecour/Nim/issues/372
+    let p = create(float)
+    p[] = 20.0
+    doAssert byLent(p)[] == 20.0
 
   proc byLent2[T](a: openarray[T]): lent T = a[0]
   doAssert byLent2(a) == 11
@@ -53,3 +52,7 @@ block:
     z = 30
   doAssert byLent3(x, y, z) == 20
 
+main2()
+when false:
+  # bug: Error: unhandled exception: 'node' is not accessible using discriminant 'kind' of type 'TFullReg' [FieldDefect]
+  static: main2()
diff --git a/tests/misc/taddr.nim b/tests/misc/taddr.nim
index 4d0aebc01e4e..17fccfabe4de 100644
--- a/tests/misc/taddr.nim
+++ b/tests/misc/taddr.nim
@@ -97,9 +97,8 @@ block:
     doAssert a2 == 10
 
   block:
-    when not defined(cpp): # pending bug #15958
-      let a = [11,12]
-      doAssert byLent(a) == [11,12]
+    let a = [11,12]
+    doAssert byLent(a) == [11,12] # bug #15958
     let a2 = (11,)
     doAssert byLent(a2) == (11,)