Skip to content

Commit 24148c3

Browse files
bastonerorikigigi
authored andcommitted
Fix missing max_iterations in overrides
Fixes aiidateam#966 All the base workchains missed to override the `max_iterations` input. This is now fixed for all of them.
1 parent 35b7721 commit 24148c3

File tree

12 files changed

+17
-0
lines changed

12 files changed

+17
-0
lines changed

Diff for: src/aiida_quantumespresso/workflows/protocols/ph/base.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
default_inputs:
22
clean_workdir: False
3+
max_iterations: 5
34
ph:
45
metadata:
56
options:

Diff for: src/aiida_quantumespresso/workflows/protocols/pw/base.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ default_inputs:
22
clean_workdir: False
33
kpoints_distance: 0.15
44
kpoints_force_parity: False
5+
max_iterations: 5
56
meta_parameters:
67
conv_thr_per_atom: 0.2e-9
78
etot_conv_thr_per_atom: 1.e-5

Diff for: src/aiida_quantumespresso/workflows/protocols/xspectra/base.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ default_inputs:
22
clean_workdir: False
33
kpoints_distance: 0.15
44
kpoints_force_parity: False
5+
max_iterations: 5
56
xspectra:
67
parameters:
78
INPUT_XSPECTRA:

Diff for: src/aiida_quantumespresso/workflows/pw/base.py

+1
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ def get_builder_from_protocol(
227227
else:
228228
builder.kpoints_distance = orm.Float(inputs['kpoints_distance'])
229229
builder.kpoints_force_parity = orm.Bool(inputs['kpoints_force_parity'])
230+
builder.max_iterations = orm.Int(inputs['max_iterations'])
230231
# pylint: enable=no-member
231232

232233
return builder

Diff for: src/aiida_quantumespresso/workflows/xspectra/base.py

+1
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ def get_builder_from_protocol(
137137
if 'settings' in inputs['xspectra']:
138138
builder.xspectra['settings'] = orm.Dict(inputs['xspectra']['settings'])
139139
builder.clean_workdir = orm.Bool(inputs['clean_workdir'])
140+
builder.max_iterations = orm.Int(inputs['max_iterations'])
140141
# pylint: enable=no-member
141142

142143
return builder

Diff for: tests/workflows/protocols/pw/test_bands/test_default.yml

+3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
bands:
2+
max_iterations: 5
23
pw:
34
code: test.quantumespresso.pw@localhost
45
metadata:
@@ -39,6 +40,7 @@ relax:
3940
base:
4041
kpoints_distance: 0.15
4142
kpoints_force_parity: false
43+
max_iterations: 5
4244
pw:
4345
code: test.quantumespresso.pw@localhost
4446
metadata:
@@ -77,6 +79,7 @@ relax:
7779
scf:
7880
kpoints_distance: 0.15
7981
kpoints_force_parity: false
82+
max_iterations: 5
8083
pw:
8184
code: test.quantumespresso.pw@localhost
8285
metadata:

Diff for: tests/workflows/protocols/pw/test_base/test_default.yml

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
clean_workdir: false
22
kpoints_distance: 0.15
33
kpoints_force_parity: false
4+
max_iterations: 5
45
pw:
56
code: test.quantumespresso.pw@localhost
67
metadata:

Diff for: tests/workflows/protocols/pw/test_relax/test_default.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
base:
22
kpoints_distance: 0.15
33
kpoints_force_parity: false
4+
max_iterations: 5
45
pw:
56
code: test.quantumespresso.pw@localhost
67
metadata:
@@ -36,6 +37,7 @@ base:
3637
base_final_scf:
3738
kpoints_distance: 0.15
3839
kpoints_force_parity: false
40+
max_iterations: 5
3941
pw:
4042
code: test.quantumespresso.pw@localhost
4143
metadata:

Diff for: tests/workflows/protocols/test_pdos/test_default.yml

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ dos:
1313
nscf:
1414
kpoints_distance: 0.1
1515
kpoints_force_parity: false
16+
max_iterations: 5
1617
pw:
1718
code: test.quantumespresso.pw@localhost
1819
metadata:
@@ -55,6 +56,7 @@ projwfc:
5556
scf:
5657
kpoints_distance: 0.15
5758
kpoints_force_parity: false
59+
max_iterations: 5
5860
pw:
5961
code: test.quantumespresso.pw@localhost
6062
metadata:

Diff for: tests/workflows/protocols/xspectra/test_base/test_default.yml

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ kpoints:
66
- - 0.0
77
- 0.0
88
- 0.0
9+
max_iterations: 5
910
xspectra:
1011
code: test.quantumespresso.xspectra@localhost
1112
core_wfc_data: '# number of core states 3 = 1 0; 2 0;

Diff for: tests/workflows/protocols/xspectra/test_core/test_default.yml

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ get_powder_spectrum: false
1919
scf:
2020
kpoints_distance: 0.15
2121
kpoints_force_parity: false
22+
max_iterations: 5
2223
pw:
2324
code: test.quantumespresso.pw@localhost
2425
metadata:

Diff for: tests/workflows/protocols/xspectra/test_crystal/test_default.yml

+2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ core:
77
clean_workdir: false
88
kpoints_distance: 0.15
99
kpoints_force_parity: false
10+
max_iterations: 5
1011
pw:
1112
code: test.quantumespresso.pw@localhost
1213
metadata:
@@ -79,6 +80,7 @@ relax:
7980
base:
8081
kpoints_distance: 0.15
8182
kpoints_force_parity: false
83+
max_iterations: 5
8284
pw:
8385
code: test.quantumespresso.pw@localhost
8486
metadata:

0 commit comments

Comments
 (0)