You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wrote this to explain the problem, before I remembered we must have a solution in the qcs-api repo:
I think we also need to somehow split the Knope release for each package into separate steps, and I'm not sure whether Knope actually supports that. The simplest but most annoying solution might be to just prohibit making changes to both packages in a single PR. The sequence of events for a release is:
Knope updates both Cargo.toml files and the Cargo.lock file to have new package versions.
We could potentially add a script to update the python/Cargo.toml file's dependency on the core qcs package at this point, but we can't update the lockfile, because the updated version won't exist on crates.io yet.
Knope pushes git commit & tags.
Cargo publishes the lib crate.
Cargo publishes the python crate.
What we need is:
Knope updates the lib crate's Cargo.toml file and the lockfile.
Cargo publishes the lib crate.
A script runs that updates the python crate's dependency on the lib crate to the newly-published version.
Knope updates the python crate's Cargo.toml file and the lockfile.
Knope pushes git commit & tags.
The text was updated successfully, but these errors were encountered:
I think we need something like this: https://gitlab.com/rigetti/qcs/clients/qcs-api-client-rust/-/blob/main/knope.toml?ref_type=heads.
I wrote this to explain the problem, before I remembered we must have a solution in the qcs-api repo:
I think we also need to somehow split the Knope release for each package into separate steps, and I'm not sure whether Knope actually supports that. The simplest but most annoying solution might be to just prohibit making changes to both packages in a single PR. The sequence of events for a release is:
Cargo.toml
files and theCargo.lock
file to have new package versions.python/Cargo.toml
file's dependency on the coreqcs
package at this point, but we can't update the lockfile, because the updated version won't exist on crates.io yet.lib
crate.python
crate.What we need is:
lib
crate'sCargo.toml
file and the lockfile.lib
crate.python
crate's dependency on thelib
crate to the newly-published version.python
crate'sCargo.toml
file and the lockfile.The text was updated successfully, but these errors were encountered: