Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field in GetSchema #79

Closed
lotus-x opened this issue May 16, 2022 · 2 comments
Closed

Missing field in GetSchema #79

lotus-x opened this issue May 16, 2022 · 2 comments
Assignees

Comments

@lotus-x
Copy link

lotus-x commented May 16, 2022

Hi,

I think References field must be included when constructing the Schema which is fetched using a schema ID

https://github.com/riferrei/srclient/blob/master/schemaRegistryClient.go#L226

Also I checked with the confluent's schema registry, and it does return the references for the request /schemas/ids/%s

@AtakanColak AtakanColak self-assigned this May 18, 2022
@AtakanColak
Copy link
Collaborator

AtakanColak commented May 24, 2022

This is a trivial addition, but I want to combine this feature with a test suite I'm workıng on for this library on Github Actions. I don't have a reliable way to test this immediately, if someone can verify the one line change has no bugs for when there are no references, please let me know.

@AtakanColak
Copy link
Collaborator

Resolved in #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants