Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer overflow in toml_string_in_overwrite #42

Open
AKuHAK opened this issue Oct 17, 2024 · 2 comments
Open

Buffer overflow in toml_string_in_overwrite #42

AKuHAK opened this issue Oct 17, 2024 · 2 comments
Labels
confirm fixed Confirm that the bug has been fixed

Comments

@AKuHAK
Copy link
Contributor

AKuHAK commented Oct 17, 2024

When using various toml files (like system and later user-defined) the data may become corrupted:
example in system toml
default_bsdfs=hdl
in user toml
default_bsdfs=exfat

then it will result in
sys.sBSDFS: exD
Screenshot 2024-10-17 at 21 14 36

@rickgaiser
Copy link
Owner

I've never seen this before. I will test this when I get the chance.

@rickgaiser
Copy link
Owner

I was not able to reproduce, but also not happy with the current TOML string handling. I changes them all to properly malloc/free a new buffer for each string used.

Can you try again and see if it's fixed?

@rickgaiser rickgaiser added the confirm fixed Confirm that the bug has been fixed label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirm fixed Confirm that the bug has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants