Check napi callee status

richerfu · richerfu · commit b11db87ad356 · 2024-12-01T11:02:15.000+08:00
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,6 @@
 build/
 .idea/
+.vscode
 
 cmake-build-debug/
 
diff --git a/include/napi-inl.h b/include/napi-inl.h
@@ -2853,7 +2853,8 @@ inline void ArrayBuffer::Detach() {
     inline T* Buffer<T>::Data() const {
         void *data = nullptr;
         size_t length = 0;
-        napi_get_buffer_info(_env, _value, &data, &length);
+        napi_status status = napi_get_buffer_info(_env, _value, &data, &length);
+        NAPI_THROW_IF_FAILED(_env, status, Buffer<T>());
         return reinterpret_cast<T*>(data);
     }
 

-Original file line number
+Diff line change
 build/
 .idea/
 +.vscode
 cmake-build-debug/
Original file line number	Diff line number	Diff line change
`@@ -2853,7 +2853,8 @@ inline void ArrayBuffer::Detach() {`
`2853`	`2853`	`inline T* Buffer<T>::Data() const {`
`2854`	`2854`	`void *data = nullptr;`
`2855`	`2855`	`size_t length = 0;`
`2856`		`- napi_get_buffer_info(_env, _value, &data, &length);`
	`2856`	`+ napi_status status = napi_get_buffer_info(_env, _value, &data, &length);`
	`2857`	`+ NAPI_THROW_IF_FAILED(_env, status, Buffer<T>());`
`2857`	`2858`	`return reinterpret_cast<T*>(data);`
`2858`	`2859`	`}`
`2859`	`2860`