Merge pull request #5 from richerfu/fix-typed-array

fix: typed array

Author: richerfu

README.md

@@ -1,6 +1,6 @@
 # node-addon-api-ohos
 
-![Platform](https://img.shields.io/badge/platform-arm64/arm/x86__64-blue) [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT) ![Ohpm Version](https://img.shields.io/badge/OhpmVersion-0.0.1-green)
+![Platform](https://img.shields.io/badge/platform-arm64/arm/x86__64-blue) [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT) ![Ohpm Version](https://img.shields.io/badge/OhpmVersion-0.0.3-green)
 
 `node-addon-api` for OpenHarmony/HarmonyNext.
 
@@ -31,11 +31,12 @@ target_link_libraries(entry PRIVATE node_addon_api_ohos)
 
 For node-addon-api-ohos, we acccepted the following environment variables:
 
-| Name                        | Description                         | Default Value |
-| --------------------------- | ----------------------------------- | ------------- |
-| NAPI_CPP_EXCEPTIONS         | Allow catch the cpp exception       | true          |
-| NAPI_DISABLE_CPP_EXCEPTIONS | Disable catch the cpp exception     | false         |
-| NAPI_NORMAL                 | Hidden some APIs or cases for Harmony | true          |
+| Name                        | Description                               | Default Value |
+| --------------------------- | ----------------------------------------- | ------------- |
+| NAPI_CPP_EXCEPTIONS         | Allow catch the cpp exception             | true          |
+| NAPI_DISABLE_CPP_EXCEPTIONS | Disable catch the cpp exception           | false         |
+| NAPI_NORMAL                 | Hidden some APIs or cases for Harmony     | true          |
+| NODE_GYP_MODULE_NAME        | `NODE_API_ADDON` use it as library's name |               |
 
 ## Build
 

include/napi-inl.h

@@ -2219,15 +2219,17 @@ inline void ArrayBuffer::Detach() {
               _type(napi_typedarray_type::napi_int8_array),
               _length(0) {
         if (value != nullptr) {
+            size_t len = 0;
             napi_status status =
                     napi_get_typedarray_info(_env,
                                              _value,
                                              &const_cast<TypedArray*>(this)->_type,
-                                             &const_cast<TypedArray*>(this)->_length,
+                                             &len,
                                              nullptr,
                                              nullptr,
                                              nullptr);
             NAPI_THROW_IF_FAILED_VOID(_env, status);
+            _length = len / ElementSize();
         }
     }
 

package/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.0.3
+- The length of a TypedArray should be divided by its element length.
+
+---
 # 0.0.2
 - Buffer should extend Object directly.
 

package/oh-package.json5

@@ -4,7 +4,7 @@
   name: "@ohos-rs/node-addon-api",
   description: "Node-addon-api for OpenHarmony/HarmonyNext",
   main: "index.ets",
-  version: "0.0.2",
+  version: "0.0.3",
   types: "libs/index.d.ts",
   dependencies: {}
 }