feat: add the ability to ignore-list sources #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Feb 20, 2023
This adds the ability to mark sources emitted into a source map as ignore-listed, which provides a hint that debuggers can utilize when dealing with these sources[^1]. The `ignoreList` option can be passed to a `MagicString` now, and will be considered when generating a source map for it. In addition that bit will also be considered when the `MagicString` is added as source to a `Bundle` (with the possibility to override the value via a parameter to `addSource`). The `x_google_ignoreList` field in the source map will only be emitted if at least one of its sources was explicitly marked with `ignoreList: true`. Otherwise - and primarily for backwards compatibility with the existing ecosystem - no `x_google_ignoreList` field is emitted. Fixes Rich-Harris#241 [^1]: https://developer.chrome.com/blog/devtools-better-angular-debugging
bmeurer
force-pushed
the
feat/ignoreList
branch
from
e80b3f8
to
5ecb1c8
Compare
antfu
approved these changes
Feb 22, 2023
|
Thanks! |
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to mark sources emitted into a source map as ignore-listed, which provides a hint that debuggers can utilize when dealing with these sources1.
The
ignoreListoption can be passed to aMagicStringnow, and will be considered when generating a source map for it. In addition that bit will also be considered when theMagicStringis added as source to aBundle(with the possibility to override the value via a parameter toaddSource). Thex_google_ignoreListfield in the source map will only be emitted if at least one of its sources was explicitly marked withignoreList: true. Otherwise - and primarily for backwards compatibility with the existing ecosystem - nox_google_ignoreListfield is emitted.Fixes #241
cc @victorporof
Footnotes
https://developer.chrome.com/blog/devtools-better-angular-debugging ↩