Fedora 39 webui: Unusable devices and /boot/efi support #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should check that there is at least one mountable filesystem present on the selected disks instead of just checking for partition presence. Related: rhbz#2235185 Related: rhbz#2231339
Only devices that can be mounted and swap and LUKS devices should be available for mount point assignment. Resolves: rhbz#2235185 Related: rhbz#2231339
vojtechtrefny
force-pushed
the
fedora-39_boot-efi
branch
from
debaae4
to
d981fe6
Compare
Related: rhbz#2234967 Related: rhbz#2231339
Just a hack with checking /sys/firmaware/efi, we need a backend function to make this properly. Resolves: rhbz#2234967 Related: rhbz#2231339
Resolves: rhbz#2234967 Related: rhbz#2231339
Related: rhbz#2234967 Related: rhbz#2231339
vojtechtrefny
force-pushed
the
fedora-39_boot-efi
branch
from
d981fe6
to
2efb50b
Compare
|
/kickstart-test --waive webui only |
M4rtinK
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5082 and #5066 for F39. Doing this in one PR to avoid merge conflicts.
Resolves: rhbz#2234967
Resolves: rhbz#2235185
Related: rhbz#2231339