Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder: Add double battle weather form change test #4383

Open
AsparagusEduardo opened this issue Apr 13, 2024 · 0 comments
Open

Reminder: Add double battle weather form change test #4383

AsparagusEduardo opened this issue Apr 13, 2024 · 0 comments
Labels
category: battle-mechanic Pertains to battle mechanics category: battle-tests Related to the automated test environment type: reminder

Comments

@AsparagusEduardo
Copy link
Collaborator

Description

#4382 fixed the issue seen here: https://www.twitch.tv/barron/clip/TameEnticingCoffeeFailFish-no2A-uR5rfNDy_Zx

However, to avoid a regression, I recommend that we add a test that replicates this issue.
Details by @skolgrahd:

if battler 1 was Cloud Nine Golduck and battler 2 was Flower Gift Cherrim, no soft lock. But move Golduck to battler 0 and you had a soft lock

Might also be worth investigating why the position of the battler was producing different results.

Version

1.8.1 (Latest release)

Upcoming/master Version

No response

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo added bug Bug category: battle-mechanic Pertains to battle mechanics category: battle-tests Related to the automated test environment labels Apr 13, 2024
@pkmnsnfrn pkmnsnfrn added type: reminder and removed bug Bug labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-mechanic Pertains to battle mechanics category: battle-tests Related to the automated test environment type: reminder
Projects
None yet
Development

No branches or pull requests

2 participants