Photon Geyser checking damage category incorrectly

[VyaxUltima]

Description

Currently, Photon Geyser's logic of when it becomes a physical move is reversed.

As seen here, Special Attack initially exceeds Attack, which means Photon Geyser should be a special move. However, Counter is used and succeeds, indicating a physical move.

Later, after Swords Dance is used, Counter fails on Photon Geyser, so it is treated as a special move, even though Attack exceeds Special Attack.

The offending line appears to be gBattleStruct->swapDamageCategory = (GetSplitBasedOnStats(battler) == SPLIT_SPECIAL);, inside src/battle_script_commands.c. If the function inside the expression returns SPLIT_SPECIAL, then that expression evaluates to 1. However, the line if (gBattleStruct != NULL && gBattleStruct->swapDamageCategory) inside src/battle_util.c returns SPLIT_PHYSICAL if it ends up evaluating to true.

Version

1.7.0 (Default)

Upcoming Version

No response

Discord contact info

No response