Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gSpeciesInfo could use a macro for types, egg groups and items to reduce redundancy #3654

Closed
Bassoonian opened this issue Dec 8, 2023 · 2 comments
Closed

gSpeciesInfo could use a macro for types, egg groups and items to reduce redundancy #3654

Bassoonian opened this issue Dec 8, 2023 · 2 comments
Labels
type: reminder

Comments

@Bassoonian
Copy link
Collaborator

Description

See #3562

Version

upcoming (Edge)

Upcoming Version

No response

Discord contact info

No response
@Bassoonian Bassoonian added bug Bug status: unconfirmed This bug has not been reproduced yet labels Dec 8, 2023
@cfmnephrite
Copy link

Something like this?

#define FIRST(a, ...) a
#define TYPES(type1, ...) {type1, FIRST(__VA_ARGS__ __VA_OPT__(,) type1)}
///
.types = TYPES(TYPE_NORMAL),

@Bassoonian Bassoonian added type: reminder and removed bug Bug status: unconfirmed This bug has not been reproduced yet labels Jan 9, 2024
@Bassoonian Bassoonian mentioned this issue Feb 8, 2024
Merged
@AlexOn1ine
Copy link
Collaborator

Since we reversed the macros in species_info I'll close this. Feel free to open if there is still something we want to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: reminder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bassoonian @cfmnephrite @AlexOn1ine