Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misuse of gLastUsedAbility #3568

Closed
kleeenexfeu opened this issue Nov 16, 2023 · 0 comments · Fixed by #3569
Closed

Misuse of gLastUsedAbility #3568

kleeenexfeu opened this issue Nov 16, 2023 · 0 comments · Fixed by #3569
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet

Comments

@kleeenexfeu
Copy link

kleeenexfeu commented Nov 16, 2023 •
edited
Loading

Description

https://github.com/rh-hideout/pokeemerald-expansion/blob/master/src/battle_util.c#L6102 checks gLastUsedAbility as if it was a u8, whereas it's a u16 now. gLastUsedAbility != 0xFF is actually a check for gorilla tactics. Must be a leftover, when abilities wouldn't go past the index 255

It probably causes some unintended behaviors

Version

1.6.2 (Default)

Upcoming Version

No response

Discord contact info

No response
@kleeenexfeu kleeenexfeu added bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet labels Nov 16, 2023
@Bassoonian Bassoonian mentioned this issue Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix assumption gLastUsedAbility is u8 Bassoonian/pokeemerald-expansion
1 participant
@kleeenexfeu