Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing White Herb tests #3501

Closed
AsparagusEduardo opened this issue Oct 31, 2023 · 0 comments · Fixed by #3611
Closed

Missing White Herb tests #3501

AsparagusEduardo opened this issue Oct 31, 2023 · 0 comments · Fixed by #3611
Assignees
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet

Comments

@AsparagusEduardo
Copy link
Collaborator

Description

Current tests don't fully encompass White Herb's effect.

If the stat stages of any of the holder's stats are negative, it consumes the White Herb and all negative stat stages are reset to be neutral.

Use PARAMETRIZE for every stat.

If a multi-strike move activates Tangling Hair, Gooey, or Weak Armor, a Pokémon will not consume the White Herb until after the final strike. If a Pokémon holding a White Herb activates multiple Pokémon's Tangling Hair or Gooey, it will not consume its White Herb until all of the Abilities have activated for that attack.

If a Pokémon with Weak Armor is hit by Knock Off, Thief, Covet, or a physical move from a Pokémon with Magician, its held White Herb will be knocked off or stolen before it has a chance to activate. If a Pokémon with Weak Armor is hit by Fling using a White Herb, the White Herb's effect will be applied before Weak Armor lowers its Defense. If a Pokémon uses a contact move that lowers its own stats (such as Superpower) on a Pokémon with Pickpocket, its held White Herb will be stolen before it has a chance to activate.

If the Pokémon with Defiant or Competitive is holding a White Herb, Defiant or Competitive will trigger before the White Herb, so the user will receive the Attack or Special Attack boost and then the lowered stat will be restored; if the same stat boosted by the Ability is lowered, the White Herb never has a chance to activate.

If a Pokémon with Contrary has one of its stats lowered by an O-Power, its held White Herb will not be activated until after a Pokémon uses a move.

TODO: split this description into multiple headers to write tests from.

Version

1.6.1 (Default)

Upcoming Version

No response

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo added bug Bug status: unconfirmed This bug has not been reproduced yet labels Oct 31, 2023
@AlexOn1ine AlexOn1ine self-assigned this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants