Disguise implementation is not working correctly

[pkmnsnfrn]

I have tried to test each line of Bulbapedia's description and provided video evidence where I could.

Broken Scenarios

• Type Change: If Mimikyu's type had been changed beforehand, it is restored to Ghost/Fairy when it changes to its Busted Form.

  • [🎥 Expected Ghost / Fairy / Grass to revert back to Ghost / Fairy.]
  • [🎥 Expected Normal / Normal to revert back to Ghost / Fairy.]

• Baton Pass: If a Pokémon that has its Ability suppressed passes that effect to a Pokémon with this Ability via Baton Pass, that effect fades.

  • [🎥 After Baton Pass, Disguise should block the incoming attack. It does not.]

Fixed Scenarios

#4360

• Light Trio Z-Moves: The Z-Moves Searing Sunraze Smash, Menacing Moonraze Maelstrom, and Light That Burns the Sky will ignore Disguise, hitting through the disguise without busting it.

  • [🎥 Menacing Moonraze Maelstrom should not be blocked by Disguise]
  • [🎥 Light That Burns the Sky should not be blocked by Disguise]

• Entry Hazards: Disguise will not protect against entry hazards.

  • [🎥 Mimikyu should take damage from Spikes.]
  • Research Question: In the core series, are entry hazards supposed to break Disguise?

• Weather: Disguise will not protect against weather damage.

  • [🎥 Mimikyu should take damage from Sandstorm.]
  • Research Question: In the core series, is weather damage supposed to break Disguise?

• Air Balloon: A held Air Balloon will be popped even if Disguise negates the damage.

  • [🎥 Air Balloon should pop after the first hit.]

• Confusion: If a Mimikyu in its Disguised Form hits itself in confusion, Disguise prevents the move from calling the damage formula.

  • [🎥 Mimikyu should not take damage from confusion.]
  • Research Question: In the core series, does confusion damage break the Substitute?

• Message: When this effect activates, the message, "Its disguise served it as a decoy!" is displayed, Mimikyu changes to its Busted Form, and finally the message, "'s disguise was busted!" is displayed.

  • [🎥 Expected message, battle popup and form change to occur, but nothing happened.]

Working Scenarios

• Damage: If a Mimikyu in its Disguised Form is hit by a damaging move, Disguise prevents the move from calling the damage formula.

  • [🎥 Video]

• Immunity: The move will thus deal no damage, and type effectiveness will not be calculated (except in case of immunity, which prevents Disguise from triggering since the move will not hit in the first place).

  • [🎥 Video]

• Multi-Hit Moves: Disguise activates at the first strike of a multi-strike move such as Water Shuriken and will not block damage from remaining strikes.

  • [🎥 Video]

• Secondary Effects: Disguise only blocks the damage from moves; additional effects of damaging moves like paralysis from Nuzzle are not prevented.

  • [🎥 Video]

• Substitute: If Mimikyu has a substitute, the substitute will take damage before Disguise.

• Weakness Policy: Weakness Policy will not activate regardless of the move's type.

  • [🎥 Video]

• Overwrite Ability: Gastro Acid, Worry Seed, and Simple Beam fail if the target has the Ability Disguise.

  • [🎥 Video]

• Copy Ability Moves: Role Play, Skill Swap, Entrainment, and Doodle fail if either Pokémon has Disguise.

  • [🎥 Video]

• Copy Ability Abilities: Disguise cannot be copied by Trace, Power of Alchemy, or Receiver.

  • [🎥 Video]
  • [🎥 Video]

• Ability Suppress: Disguise cannot be replaced by Mummy or Lingering Aroma, traded by Wandering Spirit, or suppressed by Core Enforcer or Neutralizing Gas.

  • [🎥 Video]
  • [🎥 Video]
  • [🎥 Video]

• Transform: If a Pokémon obtains Disguise with Imposter or Transform, the Ability will never activate.

  • [🎥 Video]

• Mold Breaker / Teravolt / Turboblaze: Pokémon with Mold Breaker, Teravolt or Turboblaze will ignore Disguise, hitting through the disguise without busting it.

  • [🎥 Video]
  • [🎥 Video]

• Light Trio Signature Moves: The moves Moongeist Beam, Sunsteel Strike, and Photon Geyser will ignore Disguise, hitting through the disguise without busting it.

  • [🎥 Video]
  • [🎥 Video]

Testing

The following are all the different scripts I used for testing. If I used the debug menu, I tried to show it off in the video as much as possible.

Battle against Mimikyu with Pikachu

    setflag FLAG_BADGE08_GET
    givemon SPECIES_PIKACHU, 100, 0
    setwildbattle SPECIES_MIMIKYU, 100, 0
    dowildbattle

Battle against Mimikyu with Trevenant

    setflag FLAG_BADGE08_GET
    givemon SPECIES_TREVENANT, 100, 0
    setwildbattle SPECIES_MIMIKYU, 100, 0
    dowildbattle

Battle against Trainer Rick's Mimikyu with Tyranitar

    setflag FLAG_BADGE08_GET
    givemon SPECIES_TYRANITAR, 100, 0
    trainerbattle_no_intro TRAINER_RICK, Debug_FlagsNotSetOverworldConfigMessage_Text
//you'll need to edit Rick's team to have a Mimikyu as the second Pokemon

Battle against Mimikyu with Scizor

    setflag FLAG_BADGE08_GET
    givemon SPECIES_SCIZOR, 100, 0
    setwildbattle SPECIES_MIMIKYU, 50, 0
    dowildbattle
    end

Battle against two Mimikyu with Mikimyu, Alolan Muk, and Jigglypuff

    setflag FLAG_BADGE08_GET
    givemon SPECIES_MIMIKYU, 1, 0
    givemon SPECIES_MUK_ALOLAN, 100, 0
    givemon SPECIES_JIGGLYPUFF, 1, 0
    setwildbattle SPECIES_MIMIKYU, 1, 0, SPECIES_MIMIKYU, 1, 0
    dowildbattle

Battle against Mimikyu with Cofagrigus, Runerigus, Zygarde, Ninjask, Ditto and Mimikyu

    setflag FLAG_BADGE08_GET
    givemon SPECIES_COFAGRIGUS, 100, 0
    givemon SPECIES_RUNERIGUS, 100, 0
    givemon SPECIES_ZYGARDE, 100, 0
    givemon SPECIES_NINJASK, 100,0
    givemon SPECIES_MIMIKYU, 100,0
    givemon SPECIES_DITTO,100, 0
    setwildbattle SPECIES_MIMIKYU, 100, 0
    dowildbattle

Give player Z-Power Ring and battle with Mimikyu with Rampardos, Scizor, Lunala, Solgaleo, and Ultra Necrozma

    setflag FLAG_BADGE08_GET
    additem ITEM_Z_POWER_RING, 1
    givemon SPECIES_RAMPARDOS, 100, 0
    givemon SPECIES_ZEKROM, 100, 0
    givemon SPECIES_SCIZOR, 100, 0
    givemon SPECIES_LUNALA, 100, ITEM_LUNALIUM_Z
    givemon SPECIES_SOLGALEO, 100, ITEM_SOLGANIUM_Z
    givemon SPECIES_NECROZMA_ULTRA, 100, ITEM_ULTRANECROZIUM_Z
    setwildbattle SPECIES_MIMIKYU, 100, 0
    dowildbattle

[pkmnsnfrn]

All interactions (to my knowledge) are now tested.

[AsparagusEduardo]

What happened? Was something still broken?

[AgustinGDLV]

What happened? Was something still broken?

I want to say the Baton Pass ability suppression edge case still isn't accurate, but I need to test it myself.

[AsparagusEduardo]

I'm just now realizing that this issue isn't about Mimikyu changing form, but of Disguise edge cases.

[AlexOn1ine]

Besides the fix in #3025 is there anything else broken here and what's the Baton Pass ability suppression edge case?

[pkmnsnfrn]

@AlexOn1ine I think we should assume that all of my "broken scenarios" in the OP are still boken

[AlexOn1ine]

Type Change: If Mimikyu's type had been changed beforehand, it is restored to Ghost/Fairy when it changes to its Busted Form.
Baton Pass: If a Pokémon that has its Ability suppressed passes that effect to a Pokémon with this Ability via Baton Pass, that effect fades.

Those are untested and probably still broken with PR #4360

[pkmnsnfrn]

@AlexOn1ine What would be easier for you / people fixing battle bugs:

1. update this issue and moved the fixed stuff from broken
2. close this issue, open two new issues for each of the remaining items
3. something else
4. do nothing

[AlexOn1ine]

1. update this issue and moved the fixed stuff from broken

Option 1 seems to be the most reasonable.

[hedara90]

Both scenarios have been fixed on current expansion.
Types reset back to Ghost/Fairy.
And Disguise triggers after getting Baton Passed Gastro Acid. The bit for Gastro Acid is still set to 1, but Disguise ignores it.
Don't know when it was fixed. Gonna write tests then close the issue.

[AlexOn1ine]

Both scenarios have been fixed on current expansion. Types reset back to Ghost/Fairy. And Disguise triggers after getting Baton Passed Gastro Acid. The bit for Gastro Acid is still set to 1, but Disguise ignores it. Don't know when it was fixed. Gonna write tests then close the issue.

I assumed #4360 fixed those but I was to lazy to test those cases.

[AlexOn1ine]

#5249