Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add let's go eevee and let's go pikachu species #2291

Closed
Jaizu opened this issue Sep 4, 2022 · 5 comments
Closed

Add let's go eevee and let's go pikachu species #2291

Jaizu opened this issue Sep 4, 2022 · 5 comments

Comments

@Jaizu
Copy link

Jaizu commented Sep 4, 2022

I think they fit and should be added to the pokémon expansion.
They should differ from regular ones on:
Species ID
Not being able to breed
Different movesets/learnset
Base stats
Shiny locked (not sure if this is out of scope)
Unable to evolve

Additionally, this could be an excuse to make something like not being able to deposit a certain species ID in a storage box, but I feel like that should be handled in a different github issue.

@AsparagusEduardo
Copy link
Collaborator

  • Something you missed was that they always perfect IVs.

  • Shiny lock could be a separate feature as a separate table, but with no species by default, as its not a very liked thing ^^;

something like not being able to deposit a certain species ID in a storage box

  • In LGPE you could take Pikachu and Eevee out from your party, it's just that you can still interact with them in the overworld and other stuff.

@Jaizu
Copy link
Author

Jaizu commented Sep 4, 2022

Oh, then ignore the pc box stuff.
For shiny and perfects ivs they should should into separate tables/features then? And add the new species to those tables.

@AsparagusEduardo
Copy link
Collaborator

Oh, then ignore the pc box stuff. For shiny and perfects ivs they should should into separate tables/features then? And add the new species to those tables.

Yes, but now that I think about it, instead of using tables, we could add new species flags. We only have one left anyway, so might as well expand them to u16.

@Jaizu
Copy link
Author

Jaizu commented Sep 4, 2022

Both options seem fine to me o/

@AlexOn1ine
Copy link
Collaborator

#4281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants