Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mega forms and Alternate forms do not have weight since they aren't in the dex #1547

Closed
Ryuhouji opened this issue Jun 22, 2021 · 2 comments
Closed
Labels
category: pokemon Pertains to Pokémon data and functionality

Comments

@Ryuhouji
Copy link

This causes moves like heavy slam, low kick, and grass knot to malfunction when used against these mons in battle. The game gets the .weight field from the pokedex entries. If a mon does not have a dex entry (or if someone is doing a project that only features some generations) then the moves will not work.

@Ryuhouji
Copy link
Author

I resolved this feature in my repo by adding a lookup table call to the function that actually returns weight. if this is something you are interested in checking out, let me know.

@ghoulslash ghoulslash added the category: pokemon Pertains to Pokémon data and functionality label Nov 22, 2021
@DizzyEggg
Copy link
Collaborator

This doesn't happen atm, because the GetBattlerWeight function uses SpeciesToNationalPokedexNum which has all of the forms/megas covered.

https://github.com/rh-hideout/pokeemerald-expansion/blob/upcoming/src/battle_util.c#L8341
https://github.com/rh-hideout/pokeemerald-expansion/blob/upcoming/src/pokemon.c#L1257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: pokemon Pertains to Pokémon data and functionality
Projects
None yet
Development

No branches or pull requests

4 participants