From f06f2b53d6a568834d9990f36695679d2d5d64e5 Mon Sep 17 00:00:00 2001 From: psf <77138753+pkmnsnfrn@users.noreply.github.com> Date: Fri, 12 Jul 2024 08:25:46 -0700 Subject: [PATCH] Apply suggestions from code review Made functions inline per https://github.com/rh-hideout/pokeemerald-expansion/pull/4953/files#r1675397114 Co-authored-by: Alex <93446519+AlexOn1ine@users.noreply.github.com> --- src/pokeball.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pokeball.c b/src/pokeball.c index 82a71f9473ad..b09a238ecfc4 100644 --- a/src/pokeball.c +++ b/src/pokeball.c @@ -616,7 +616,7 @@ static void Task_DoPokeballSendOutAnim(u8 taskId) PlaySE(SE_BALL_THROW); } -static void DoPokeballSendOutSoundEffect(void) +static inline void DoPokeballSendOutSoundEffect(void) { if (B_THROW_BALLS_SOUND < GEN_5) return; @@ -624,7 +624,7 @@ static void DoPokeballSendOutSoundEffect(void) PlaySE(SE_BALL_THROW); } -static void *GetOpponentMonSendOutCallback(void) +static inline void *GetOpponentMonSendOutCallback(void) { return (B_OPPONENT_THROW_BALLS >= GEN_6) ? SpriteCB_MonSendOut_1 : SpriteCB_OpponentMonSendOut; } @@ -1130,7 +1130,7 @@ static void SpriteCB_BallThrow_CaptureMon(struct Sprite *sprite) } } -static bool32 IsBattlerPlayer(u32 battler) +static inline bool32 IsBattlerPlayer(u32 battler) { return (battler % B_POSITION_PLAYER_RIGHT) ? FALSE : TRUE; }