Skip to content

Conversation

@carbonin
Copy link
Collaborator

@carbonin carbonin commented Aug 6, 2025

This was added because of a bug and must now be fixed in the latest version.

Before this fix the integration environment was returning responses
like:

{
    "detail": {
        "response": "Unable to process this request",
        "cause": "Model gemini/gemini/gemini-2.0-flash from provider gemini not found in available models"
    }
}

cc @omertuc

Summary by CodeRabbit

  • Chores
    • Updated configuration to simplify the default model path for inference by removing redundant provider information. No changes to functionality or user interface.

@openshift-ci openshift-ci bot requested review from eranco74 and jhernand August 6, 2025 20:42
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Aug 6, 2025

Walkthrough

The changes update the default_model field in both lightspeed-stack.template.yaml and template.yaml configuration files. The model path is simplified by removing a redundant segment and, in one file, by referencing only the model variable instead of a provider/model combination. No other configuration or code is modified.

Changes

Cohort / File(s) Change Summary
Model Path Simplification
lightspeed-stack.template.yaml, template.yaml
Updated the default_model field to remove a redundant provider/model path segment, simplifying the model reference.

Sequence Diagram(s)

Not applicable: The changes are limited to configuration value adjustments and do not affect control flow or introduce new features.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • carbonin
  • omertuc

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3be803 and d5b7737.

📒 Files selected for processing (2)
  • lightspeed-stack.template.yaml (1 hunks)
  • template.yaml (1 hunks)
🔇 Additional comments (2)
lightspeed-stack.template.yaml (1)

31-31: Ignore parameter suggestion
The ${LLAMA_STACK_2_0_FLASH_MODEL} parameter isn’t declared or imported in lightspeed-stack.template.yaml, so referencing it here would break the template. You can safely keep the hard-coded gemini/gemini-2.0-flash value unless you explicitly add that parameter to this file.

Likely an incorrect or invalid review comment.

template.yaml (1)

146-146: Removal of provider prefix resolves the double-prefix bug – LGTM

${LLAMA_STACK_2_0_FLASH_MODEL} already contains the gemini/ prefix, so deleting the explicit ${LLAMA_STACK_INFERENCE_PROVIDER}/ piece prevents gemini/gemini/... duplication. The surrounding default_provider field still supplies the provider ID, so behaviour stays consistent.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was added because of a bug and must now be fixed in the latest
version.

Before this fix the integration environment was returning responses
like:

```
{
    "detail": {
        "response": "Unable to process this request",
        "cause": "Model gemini/gemini/gemini-2.0-flash from provider gemini not found in available models"
    }
}
```
@openshift-ci openshift-ci bot added the approved label Aug 6, 2025
@carbonin carbonin force-pushed the dedupe-default-provider-name branch from d30e768 to d5b7737 Compare August 6, 2025 20:43
@oourfali
Copy link

oourfali commented Aug 6, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2025

@oourfali: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc
Copy link
Member

omertuc commented Aug 7, 2025

/lgtm

@omertuc
Copy link
Member

omertuc commented Aug 7, 2025

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Aug 7, 2025

@omertuc: The following commands are available to trigger required jobs:

/test images

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omertuc omertuc merged commit b166803 into rh-ecosystem-edge:main Aug 7, 2025
3 of 5 checks passed
@carbonin carbonin deleted the dedupe-default-provider-name branch August 7, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants