add random job id to eval tests template

[maorfr]

part of https://issues.redhat.com/browse/MGMT-21415

this change will cause a new job to be created after each deployment, guaranteeing more reliable results.

Summary by CodeRabbit

• Chores
  • CI jobs now use dynamically generated names with a short unique ID appended, improving traceability across runs and reducing name collisions.
  • Introduced a template parameter to auto-generate the short ID, ensuring each job run is distinguishable without manual input.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maorfr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

Adds a generated JOB_ID parameter to test/prow/template.yaml and updates the Job metadata.name to include this parameter, making the job name dynamic.

Changes

Cohort / File(s)	Summary
Prow template parameterization test/prow/template.yaml	Added parameter JOB_ID with generate: expression from "[0-9a-f]{7}". Updated Job.metadata.name from "assisted-chat-eval-test" to "assisted-chat-eval-test-${JOB_ID}". Placed JOB_ID before IMAGE_NAME in parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly and accurately summarizes the primary change by indicating that a random job ID is being added to the evaluation tests template, with no extraneous details and clear wording.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[eranco74]

/lgtm

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

test/prow/template.yaml (2)

9-16: Add job-id labels for traceability.

Including the JOB_ID in labels (Job and Pod template) makes log filtering, cleanup, and metrics grouping easier when multiple runs overlap.

   metadata:
     name: assisted-chat-eval-test-${JOB_ID}
     labels:
       app: assisted-chat-eval-test
+      job-id: ${JOB_ID}
...
       metadata:
         labels:
           app: assisted-chat-eval-test
+          job-id: ${JOB_ID}

---

46-48: Generation is fine; document intent and confirm apply/create flow.

• Add a brief description to clarify usage.
• If your pipeline uses oc create (not oc apply), consider using metadata.generateName: "assisted-chat-eval-test-" instead of a parameter. Otherwise your current approach is preferable.

 - name: JOB_ID
   generate: expression
   from: "[0-9a-f]{7}"
+  description: "Random 7-hex suffix for Job name; leave empty to auto-generate"

Please confirm whether your deployment uses oc apply or oc create so we know if generateName is viable without changing behavior.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 322aae0 and 257e3da.

📒 Files selected for processing (1)

• test/prow/template.yaml (2 hunks)

[openshift-ci]

@maorfr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/eval-test	257e3da	link	false	/test eval-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.