Fix sql sanitization of multi geoms #81
Open
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuonOmo
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Thank you for pushing these changes ! I have a few questions left, and I'd also like a second reviewer to see if that is really the direction we want to go (there might be issues related to this choice that we're not seeing..) @keithdoggett ?
| module MultiGeomSanitization | ||
| private | ||
|
|
||
| # NOTE connection and value order is swapped in Rails 8 |
There was a problem hiding this comment.
What should we do about this note?
| @@ -124,6 +124,16 @@ def test_arel_visit_RGeo_ActiveRecord_SpatialNamedFunction_with_distinct | |||
| assert_equal("SPATIAL_FUNC(DISTINCT ST_GeomFromText('POINT (1.0 2.0)'), ST_GeomFromText('LINESTRING (1.0 2.0, 2.0 3.0)'))", sql.value) | |||
| end | |||
|
|
|||
| def test_multi_geom_sanitization | |||
| multi_geom = RGeo::Geos.factory.parse_wkt("MULTIPOLYGON (((0 0, 0 1, 1 1, 0 0)),((1 1, 0 0, 0 1, 1 1)))") | |||
| sql = "ST_DWithin(geom, :geom, :buffer)" | |||
There was a problem hiding this comment.
why do we need that st_dwithin function for the test?
| @@ -9,6 +9,7 @@ | |||
| require "minitest/autorun" | |||
| require "rgeo-activerecord" | |||
| require "support/fake_record" | |||
| require "active_support/core_ext/date/acts_like" | |||
| @@ -88,6 +88,10 @@ def quote(thing, column = nil) | |||
| "'#{thing.to_s.gsub("'", "\\\\'")}'" | |||
| end | |||
| end | |||
|
|
|||
| def cast_bound_value(value) | |||
There was a problem hiding this comment.
why using this fake record class rather than any record?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79