Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to remove jruby support #393

Open
seuros opened this issue Mar 3, 2024 · 7 comments
Open

Proposal to remove jruby support #393

seuros opened this issue Mar 3, 2024 · 7 comments

Comments

@seuros
Copy link
Contributor

seuros commented Mar 3, 2024

We should consider removing JRuby code from the GitHub Action as it is currently untested, and Rails 7.1 lacks official support.

It's unclear if there's active JRuby utilization.

@BuonOmo
Copy link
Member

BuonOmo commented Mar 4, 2024

I do not see JRuby in the github action tests.yml. What is the GitHub Action you are referencing?

@seuros
Copy link
Contributor Author

seuros commented Mar 4, 2024

That what i said ! We are not testing it.

however we have code like this.

Jruby don't support rails 7.1 and this gem current release require ~> 7.1.0

@BuonOmo
Copy link
Member

BuonOmo commented Mar 4, 2024

I would not act on it until there is a real need (e.g. some jruby user is complaining, or the jruby code is generating failures in the main codebase)

@seuros
Copy link
Contributor Author

seuros commented Mar 4, 2024

@BuonOmo , it not possible to install this gem with jruby. This is misleading in the readme.

@keithdoggett
Copy link
Member

@seuros thanks for looking into that. Do you know if this new with ActiveRecord >7?

@seuros
Copy link
Contributor Author

seuros commented Mar 21, 2024

@keithdoggett, 7.1 is not released: https://github.com/jruby/activerecord-jdbc-adapter.

I could not make this adapter work with jruby and rails 7.0 either.

@keithdoggett
Copy link
Member

@seuros got it thanks for that. It looks like it should be working for ActiveRecord 7.0 and 7.1 is under development. Do you have any idea why it's not working for 7.0 since it should be supported? Do we need to bump the version of the adapter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants