Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complements in interrogative types should go to the back of the sentence in Dutch #3

Open
Barachia opened this issue Feb 26, 2020 · 0 comments

Comments

@Barachia
Copy link

Describe the bug
When formulating an interrogative type and adding a postmodifier, this will not be added to the end of the sentence

To Reproduce
Steps to reproduce the behavior:

final private static Lexicon lexicon_nl = new simplenlg.lexicon.dutch.XMLLexicon();
final private static NLGFactory factory_nl = new NLGFactory(lexicon_nl);
final private static Realiser realiser_nl = new Realiser();

SPhraseSpec clause3 = factory_nl.createClause();
NPPhraseSpec subject = factory_nl.createNounPhrase("JIJ");
PPPhraseSpec aboutJan = factory_nl.createPrepositionPhrase("over","Jan");
subject.setFeature(Feature.PRONOMINAL, true);
subject.setFeature(Feature.PERSON, Person.SECOND);
clause3.setSubject(subject);
clause3.setVerb("denk");
clause3.addPostModifier(aboutJan);
clause3.setFeature(Feature.INTERROGATIVE_TYPE, InterrogativeType.WHAT_OBJECT);
String output3 = realiser_nl.realiseSentence(clause3);
System.out.println(output3);	

Expected behavior
I added a fix for taking the right morphology for question types for Person.SECOND, so the verb is denkt most likely in other cases, though in the debug output, also the inflection might differ.

The expected output:
Wat denk jij over Jan?

The actual output:
Wat denk over Jan jij?

Java version
JDK 8 and JDK 13

Additional context
Debug output: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant