feat!: Removed jms/serializer dependency and attributes.

Author: ambroisemaupate

.github/workflows/run-test.yml

@@ -17,7 +17,7 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                php-version: ['8.1', '8.2', '8.3']
+                php-version: ['8.1', '8.2', '8.3', '8.4']
         steps:
             - uses: shivammathur/setup-php@v2
               with:
@@ -33,8 +33,8 @@ jobs:
                       ${{ runner.os }}-php-${{ matrix.php-version }}-
             - name: Install Dependencies
               run: composer install --no-scripts --no-ansi --no-interaction --no-progress
-            - name: Run PHP Code Sniffer
-              run: vendor/bin/phpcs -p ./src
+            - name: Run PHP Code Style Fixer
+              run: vendor/bin/php-cs-fixer check --ansi -vvv
             - name: Run unit tests
               run: vendor/bin/phpunit
             - name: Run PHPStan

.gitignore

@@ -106,3 +106,4 @@ modules.xml
 # End of https://www.gitignore.io/api/composer,phpstorm+all
 
 coverage
+/.php-cs-fixer.cache

.php-cs-fixer.dist.php

@@ -0,0 +1,19 @@
+<?php
+
+$finder = (new PhpCsFixer\Finder())
+    ->in([
+        __DIR__.'/tests',
+        __DIR__.'/src',
+    ])
+;
+
+return (new PhpCsFixer\Config())
+    ->setRules([
+        '@Symfony' => true,
+        'blank_line_after_opening_tag' => true,
+        'declare_strict_types' => true,
+    ])
+    ->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect())
+    ->setRiskyAllowed(true)
+    ->setFinder($finder)
+;

LICENSE.md

@@ -1,7 +1,7 @@
 MIT License
 -----------
 
-Copyright (c) 2024 Rezo Zero
+Copyright (c) 2025 Rezo Zero
 Permission is hereby granted, free of charge, to any person
 obtaining a copy of this software and associated documentation
 files (the "Software"), to deal in the Software without

Makefile

@@ -1,5 +1,5 @@
 
 test:
-	php vendor/bin/phpcbf -p
+	php vendor/bin/php-cs-fixer fix --ansi -vvv
 	php vendor/bin/phpunit
 	php vendor/bin/phpstan analyse -c phpstan.neon

composer.json

@@ -12,16 +12,15 @@
     "require": {
         "php": ">=8.1",
         "psr/cache": "^1.0 || ^2.0 || ^3.0",
-        "jms/serializer": "^3.7",
         "symfony/serializer": ">=5.4",
         "symfony/cache": ">=5.4",
         "doctrine/collections": ">=1.6"
     },
     "require-dev": {
-        "squizlabs/php_codesniffer": "^3.3",
-        "phpstan/phpstan": "^1.8.2",
+        "phpstan/phpstan": "^2.1.4",
         "phpunit/phpunit": "^9.5",
-        "symfony/property-access": ">=5.4"
+        "symfony/property-access": ">=5.4",
+        "friendsofphp/php-cs-fixer": "^3.68"
     },
     "autoload": {
         "psr-4": {

phpstan.neon

@@ -6,3 +6,4 @@ parameters:
         - identifier: missingType.iterableValue
         - identifier: missingType.generics
     reportUnmatchedIgnoredErrors: false
+    treatPhpDocTypesAsCertain: false

src/AbstractCycleAwareWalker.php

@@ -6,24 +6,23 @@
 
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
-use JMS\Serializer\Annotation as Serializer;
-use Symfony\Component\Serializer\Annotation as SymfonySerializer;
+use Symfony\Component\Serializer\Annotation as Serializer;
 
 abstract class AbstractCycleAwareWalker extends AbstractWalker
 {
     public const MAX_CALL = 99;
 
-    #[
-        Serializer\Exclude,
-        SymfonySerializer\Ignore
-    ]
+    /**
+     * @var array<int, int>
+     */
+    #[Serializer\Ignore]
     private array $itemIds = [];
 
     /**
      * Prevent Walker to collect duplicate objects and enter into
      * infinite loop.
      *
-     * @inheritDoc
+     * {@inheritDoc}
      */
     public function getChildren(): Collection
     {
@@ -36,7 +35,6 @@ public function getChildren(): Collection
     }
 
     /**
-     * @param object|null $item
      * @return bool Return TRUE if item has not overpassed the MAX_CALL limit
      */
     protected function registerItem(?object $item): bool
@@ -47,12 +45,14 @@ protected function registerItem(?object $item): bool
         $itemId = \spl_object_id($item);
         if (!array_key_exists($itemId, $this->itemIds)) {
             $this->itemIds[$itemId] = 1;
+
             return true;
         }
-        $this->itemIds[$itemId]++;
+        ++$this->itemIds[$itemId];
         if ($this->itemIds[$itemId] <= self::MAX_CALL) {
             return true;
         }
+
         return false;
     }
 }