Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report files checked #72

Open
abitrolly opened this issue Jan 15, 2025 · 2 comments
Open

Report files checked #72

abitrolly opened this issue Jan 15, 2025 · 2 comments

Comments

@abitrolly
Copy link
Contributor

Unfortunately shellcheck doesn't report files being checked - koalaman/shellcheck#2228

And reviewdog also doesn't report mistakes - pkgxdev/setup#259

So it is not clear if it is reviewdog or shellcheck failing, but if there was shellcheck reporting to console, at least one part could be more clear.

@shogo82148
Copy link
Contributor

This is the intended behavior.
Reviewdog reports only the issues found in the changes made within the Pull Request.
If there are differences in the Pull Request, it will display the issues as shown in the link below:

@abitrolly
Copy link
Contributor Author

abitrolly commented Jan 15, 2025

So it is a technical limitation that it it impossible to comment on lines that are not changed, right?

In that case it still would be nice for reviewdog to report which files were detected (and they were detected, because they have changes) and which shellcheck lines it was able (and not able) to report.

So...

  1. List all files (and say that these are only changed ones)
  2. Get all shellchecks
  3. List all shellchecks that are reported
  4. List shellchecks that were left out for now, maybe with a diff/patch to be applied manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants