Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card var updates #430

Open
3 tasks
blazebarsamian opened this issue Sep 11, 2019 · 0 comments
Open
3 tasks

Card var updates #430

blazebarsamian opened this issue Sep 11, 2019 · 0 comments
Labels
designy pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@blazebarsamian
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?
Theres a few things that are happening:

  • there are more card vars at the top of Cards.scss than what's in harmonium-settings.scss
  • I would kind of like the borders that are used for Card-header and Card-footer to be a var that uses $card-border as a default. $card-interior-border: $card-border. Because if your $card-border is a different color than $divider-color then the borders for card-header and card-footer look a little funny when theyre fleshed against the card border.

What is the expected behavior?

  • all vars that are in Cards.scss should also be included in harmonium-settings.scss
@blazebarsamian blazebarsamian added designy pinned tickets that shouldnt be deleted until completed and this label is removed labels Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
designy pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blazebarsamian