Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design - Color Updates #376

Open
CheetoMao opened this issue Jan 22, 2019 · 1 comment
Open

Design - Color Updates #376

CheetoMao opened this issue Jan 22, 2019 · 1 comment
Assignees
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@CheetoMao
Copy link
Contributor

Placeholder ticket for Laura to update how product colors are handled in Harmonium.

Some thoughts:

Colors need better structure

  • We use sass to darken different variables for :hover and :active states
    (see settings-templates/harmonium-settings.scss line 137)
  • Color management mixins
    (documentation needed! Located in scss/mixins/_colors.scss if you wanna check those out)
  • We have a sketch product color palette with suggested dark and light versions of the brand colors that meet WCAG contrast standards.
    We should include the dark and light versions of brand colors. We should consistently use vars or sass math in order to create those colors.

This should be way easier to manage:

  • scss/vars/_color-palette-defaults.scss
    Default colors for Harmonium, written with !default so that they can be easily overwritten
  • settings-templates/_color-palette.scss
    This is just for testing, this file is not imported in Harmonium unless you manually add it. It exists so that you can test out your vars and make sure they override the defaults correctly.
  • settings-templates.zip
    This is a zip of the settings-templates/ colors and settings files. This is what users will download from Harmonium in order to start styling their project.
@CheetoMao CheetoMao self-assigned this Jan 22, 2019
@revelry-stalebot
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@blazebarsamian blazebarsamian added the pinned tickets that shouldnt be deleted until completed and this label is removed label May 31, 2019
@revelry-stalebot revelry-stalebot bot removed the stale label May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

2 participants