Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaUploader - Allow updating of the accept prop #359

Open
1 of 3 tasks
bryanjos opened this issue Dec 11, 2018 · 5 comments
Open
1 of 3 tasks

MediaUploader - Allow updating of the accept prop #359

bryanjos opened this issue Dec 11, 2018 · 5 comments
Labels
2 - in progress pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@bryanjos
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?
MediaUploader sets the accept prop to image/*, video/*.
https://github.com/revelrylabs/harmonium/blob/master/src/MediaUploader.js#L171

For bugs: please provide steps to reproduce and tell us a little about your environment (e.g., what OS and version of the package you're using)

give us enough information to properly diagnose the bug

What is the expected behavior?
accept prop should be able to be set

For feature requests: why should the behavior change?

explain why your feature request is a good idea

Other information (we love stack traces!)

@bryanjos
Copy link
Contributor Author

@radditude
Copy link
Contributor

Good catch - there's already a supportedFileTypes prop that takes an array of mimetypes so we should be able to use that to set accept on the input.

@CurtisVonRubenhoff
Copy link
Contributor

CurtisVonRubenhoff commented Dec 12, 2018

I'm gonna take care of this jk i'm not

@revelry-stalebot
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@blazebarsamian blazebarsamian added the pinned tickets that shouldnt be deleted until completed and this label is removed label May 31, 2019
@revelry-stalebot revelry-stalebot bot removed the stale label May 31, 2019
@CurtisVonRubenhoff CurtisVonRubenhoff removed their assignment Jun 7, 2019
@CurtisVonRubenhoff
Copy link
Contributor

forgot i was assigned to this and never did it. will take a look again next eng-meeting working session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - in progress pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

4 participants