Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare margins as inline and block instead of top/right/bottom/left for rtl language compatibility #140

Open
pkd2512 opened this issue Dec 15, 2023 · 1 comment
Open

Declare margins as inline and block instead of top/right/bottom/left for rtl language compatibility #140

pkd2512 opened this issue Dec 15, 2023 · 1 comment
Assignees
@pkd2512
Labels
discussion Needs talking through SCSS

Comments

@pkd2512
Copy link
Member

pkd2512 commented Dec 15, 2023 •
edited
Loading

image image

https://developer.mozilla.org/en-US/docs/Web/CSS/margin-block
https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline
@pkd2512 pkd2512 added discussion Needs talking through SCSS labels Dec 15, 2023
@pkd2512 pkd2512 self-assigned this Dec 15, 2023
@hobbes7878 hobbes7878 mentioned this issue Apr 11, 2024
Merged
1 task
@pkd2512
Copy link
Member Author

pkd2512 commented Apr 11, 2024 •
edited
Loading

  • Keep token names r/l but change all margin-/padding-left/right to inline-start/inline-end
  • Update Block components
  • customWellWidths.md Change the margin on fluid declaration
  • Hero component graphic positioning
  • _width.css .w-full-fluid
  • Photocarousel component paddings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkd2512 pkd2512

Labels
discussion Needs talking through SCSS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pkd2512