Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter (documentation) #96

Open
ondohotola opened this issue Jan 4, 2023 · 2 comments
Open

filter (documentation) #96

ondohotola opened this issue Jan 4, 2023 · 2 comments

Comments

@ondohotola
Copy link

In the documentation there are two references to 'filter':

lambda r: r['Amount'] > 10
lambda tr: tr['amount'] > 10

Their use in an amount column with decimals results in

No data to write. '>' not supported between instances of 'str' and 'int'. Try again with '-c' option.

Hence it should perhaps be mentioned in the documentation and changed in the documentation to something like

'filter': lambda tr: float(tr['Amount']) > 10.0

in order to not surprise an unsuspecting user

@ondohotola ondohotola changed the title filter (documentation filter (documentation) Jan 4, 2023
@reubano
Copy link
Owner

reubano commented Jan 20, 2023

Good catch. Can you submit a PR with this change?

@ondohotola
Copy link
Author

I have absolutely no idea how to do a Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants