Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding parameter only for reading, not for writing #27

Open
alper opened this issue Nov 15, 2017 · 1 comment
Open

Encoding parameter only for reading, not for writing #27

alper opened this issue Nov 15, 2017 · 1 comment

Comments

@alper
Copy link
Collaborator

alper commented Nov 15, 2017

I think the encoding parameter should only be used to read in files. Anything produced should be in utf-8 regardless.

I have to set the parameter because my bank returns files in windows-1252 but I have zero interest in producing a file in that same format. I think that may be the case for more users.

Alternatively, there could be a new parameter to override the output encoding.

@reubano
Copy link
Owner

reubano commented Nov 16, 2017

Good point! Not sure when I'll have the time to address this. PRs welcome of course :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants